Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[engine] Fix resolution of default variable value which contains colon #2590

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

ikalinin1
Copy link
Member

@ikalinin1 ikalinin1 commented Mar 17, 2022

Fixes #2588

@ikalinin1 ikalinin1 requested review from valfirst and uarlouski March 17, 2022 13:13
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2590 (efecc71) into master (4758abd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             master    #2590    +/-   ##
==========================================
  Coverage     96.59%   96.59%            
+ Complexity     5682     5503   -179     
==========================================
  Files           779      779            
  Lines         15819    15820     +1     
  Branches       1045     1045            
==========================================
+ Hits          15281    15282     +1     
  Misses          414      414            
  Partials        124      124            
Impacted Files Coverage Δ
.../src/main/java/org/vividus/variable/Variables.java 100.00% <100.00%> (ø)
...ain/java/org/vividus/steps/ui/web/NestedSteps.java 100.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 4e6c9c3 into master Mar 18, 2022
@valfirst valfirst deleted the 2588 branch March 18, 2022 04:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default variable value with the colon resolved incorrectly
3 participants